Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-1792

build.sh fails with command line arguments with spaces

    XMLWordPrintable

Details

    Description

      An execution like:

      ./build.sh validate -Dmaven.local.repo="asd dsa"

      Fails because handling of command line arguments of build.sh is broken.

      btw I can't understand why there should be this block of code:

          for param in $@ ; do
              case $param in
                  ## -s .../settings.xml - don't use our own.
                  -s)      MVN_SETTINGS_XML_ARGS="";   ADDIT_PARAMS="$ADDIT_PARAMS $param";;
                  -*)      ADDIT_PARAMS="$ADDIT_PARAMS $param";;
                  clean)   MVN_GOAL="$MVN_GOAL$param ";;
                  test)    MVN_GOAL="$MVN_GOAL$param ";;
                  install) MVN_GOAL="$MVN_GOAL$param ";;
                  deploy)  MVN_GOAL="$MVN_GOAL$param ";;
                  site)    MVN_GOAL="$MVN_GOAL$param ";;
                  *)       ADDIT_PARAMS="$ADDIT_PARAMS $param";;
              esac
          done

      I can't spot anything useful it does but anyways, I'll prepare a pull request for fixing it in a minute.

      Attachments

        Activity

          People

            akostadi1@redhat.com Aleksandar Kostadinov
            akostadi1@redhat.com Aleksandar Kostadinov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: