-
Enhancement
-
Resolution: Unresolved
-
Major
-
None
-
None
-
None
-
---
-
---
- replace injector with supplier in all service impl classes
- remove all getter methods of InjectedValue in all service impl classes
- add a service consumer to all service impl classes
- update the constructor to take service consumers and suppliers
- update service wiring to use ServiceBuilder.provides() and ServiceBuilder.requires() methods
From Richard Opalka's comments: Sure @chengfang , the difference between using org.jboss.msc.Service and org.jboss.msc.service.Service are the following:
Services implementing new API org.jboss.msc.service will throw UnsupportedOperationException when calling the following deprecated methods on their service controller:
- ServiceController.getValue()
- ServiceController.awaitValue()
- ServiceController.awaitValue(long,TimeUnit)
- ServiceController.getService()
By implementing deprected org.jboss.msc.service.Service interface aforementioned deprecated methods backward compatibility is maintained.
I didn't refactor these services because these deprecated methods were used for this services and my main purpose for this PR was fixing just dependencies declaration because ATM I am cleaning up org.jboss.msc.value and org.jboss.msc.injection package usages.
These ServiceController methods were deprecated because they are exposing MSC runtime internals to API users.
- incorporates
-
WFLY-16984 Rewrite batch subsystem to use new MSC values API
- Closed
- is incorporated by
-
WFLY-16850 batch subsystem code standardization
- Open
- is related to
-
WFLY-16930 Batch subsystem should maintain its own cache of services
- Coding In Progress