Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-16128

[allowlist/blocklist] Problematic Language usage deprecation and replacement in testsuite

XMLWordPrintable

      Need to replace the problematic language usages testsuit (group them together for convenience). See the linked issue WFLY-14053 for common dictionary.

      Some sample occurrences:

      $ git grep -i 'black\s*list'

      testsuite/integration/basic/pom.xml:                                        <exclude>org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java</exclude>
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterDisabledTestCase.java:    // Disables unmarshalling blacklisting.
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterDisabledTestCase.java:        testBlacklistDisabled(false);
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterDisabledTestCase.java:        testBlacklistDisabled(true);
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterDisabledTestCase.java:    private void testBlacklistDisabled(boolean http) throws NamingException {
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterDisabledTestCase.java:        Serializable blacklisted = getTemplatesImpl();
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterDisabledTestCase.java:        Response response = bean.sayHello(new Request(blacklisted));
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterTestCase.java:    public void testRemotingBlacklist() throws NamingException {
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterTestCase.java:        testBlacklist(false);
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterTestCase.java:    public void testHttpBlacklist() throws NamingException {
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterTestCase.java:        testBlacklist(true);
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterTestCase.java:    private void testBlacklist(boolean http) throws NamingException {
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterTestCase.java:        Serializable blacklisted = getTemplatesImpl();
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterTestCase.java:            Response response = bean.sayHello(new Request(blacklisted));
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/ejb/remote/requestdeserialization/UnmarshallingFilterTestCase.java:            set.add(blacklisted);
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:@ServerSetup(DeserializationBlackListTestCase.SetupTask.class)
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:public class DeserializationBlackListTestCase {
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:        private static final String CF_NAME = "myBlackListCF";
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:        JavaArchive archive = ShrinkWrap.create(JavaArchive.class, "DeserializationBlackListTestCase.jar")
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:    public void testDeserializationBlackList() throws NamingException {
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:        // UUID is black listed, any other Serializable must be deserialized.
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:    public void testDeserializationBlackListFromRegularConnectionFactory() throws NamingException {
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:        // all classes are black listed
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationMessagingBean.java:                        name = "java:comp/env/myBlackListCF",
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationMessagingBean.java:    public static final String BLACK_LIST_CF_LOOKUP = "java:comp/env/myBlackListCF";
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationMessagingBean.java:    public static final String BLACK_LIST_REGULAR_CF_LOOKUP = "java:/jms/myBlackListCF";
      
      
      $ git grep -i 'white\s*list'  testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:    public void testDeserializationWhiteList() throws NamingException { testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationBlackListTestCase.java:        // UUID is white listed, any other Serializable must not be deserialized.
      testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationMessagingBean.java:                        name = "java:comp/env/myWhiteListCF", testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/messaging/security/DeserializationMessagingBean.java:    public static final String WHITE_LIST_CF_LOOKUP = "java:comp/env/myWhiteListCF";
        

      Also grep for other problematic terms like master, slave, etc.

              parsharm Parul Sharma
              mshikalw Moulali Shikalwadi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: