Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-16125

[allowlist/blocklist] Problematic Language usage deprecation and replacement in jdr, ee

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • Major
    • 27.0.0.Alpha1, 27.0.0.Final
    • None
    • JDR
    • None

    Description

      Need to replace the problematic language usages in jdr, ee and some other directories (group them together for convenience).  See the linked issue WFLY-14053 for common dictionary.

      Some sample occurrences:

      $ git grep -i 'black\s*list'
      ee-feature-pack/common/javadoc/extractPublicApiArtifactsList.sh:###  Blacklisted ->  prepend '#'.
      ee-feature-pack/common/javadoc/extractPublicApiArtifactsList.sh:    if grep --quiet "$ARTIFACT\$" $DIRNAME/artifactsBlacklist.txt ; then echo -n "# " >> $TARGET/artifacts.in.tmp-blist.txt; fi
      ee-feature-pack/common/javadoc/extractPublicApiArtifactsList.sh:echo '    <!-- Blacklisted artifacts - see build/javadoc/artifactsBlacklist.txt. -->'
      ee-feature-pack/common/javadoc/extractPublicApiArtifactsList.sh:cat $DIRNAME/artifactsBlacklist.txt   | sed '/^$/d' | sed 's#.*#    <exclude>\0</exclude>#'
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/commands/CollectFiles.java:    private Filters.BlacklistFilter blacklistFilter = Filters.wildcardBlackList();
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/commands/CollectFiles.java:        blacklistFilter.add(pattern);
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/commands/CollectFiles.java:        List<VirtualFile> matches = root.getChildrenRecursively(Filters.and(this.filter, this.blacklistFilter));
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:    public static BlacklistFilter wildcardBlackList() {
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:        return new WildcardBlacklistFilter();
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:    public static BlacklistFilter wildcardBlacklistFilter(final String... patterns){
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:        return new WildcardBlacklistFilter(patterns);
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:    public static BlacklistFilter regexBlackList() {
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:        return new RegexBlacklistFilter();
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:    public static BlacklistFilter regexBlackList(String... patterns) {
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:        return new RegexBlacklistFilter(patterns);
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:    public interface BlacklistFilter extends VirtualFileFilter {
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:    private static class WildcardBlacklistFilter implements BlacklistFilter {
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:        public WildcardBlacklistFilter() {
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:        public WildcardBlacklistFilter(final String... patterns) {
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:    private static class RegexBlacklistFilter implements BlacklistFilter {
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:        public RegexBlacklistFilter(){
      jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/vfs/Filters.java:        public RegexBlacklistFilter(final String... patterns){
      jdr/jboss-as-jdr/src/test/java/org/jboss/as/jdr/JdrTestCase.java:    public void testBlackListFilter() {
      jdr/jboss-as-jdr/src/test/java/org/jboss/as/jdr/JdrTestCase.java:        VirtualFileFilter blf = Filters.regexBlackList();

       

      $ git grep -i 'white\s*list' 
      
      docs/src/main/asciidoc/_admin-guide/subsystem-configuration/MicroProfile_JWT.adoc:|smallrye.jwt.whitelist.algorithms

       
      Also grep for other problematic terms like master, slave, etc.

      Attachments

        Issue Links

          Activity

            People

              mshikalw Moulali Shikalwadi
              cfang@redhat.com Cheng Fang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: