Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-12971

SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: MP Metrics
    • Labels:
      None

      Description

      SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish

      https://github.com/smallrye/smallrye-metrics/blob/master/implementation/src/main/java/io/smallrye/metrics/JmxWorker.java#L156

      • iterate entrySet instead of keySet
      • can it happen that there are more entries with value '*' ?
      • shouldn't the for cycle end when the (first?) match is found ?

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                jmesnil Jeff Mesnil
                Reporter:
                rsvoboda Rostislav Svoboda
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: