Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-12971

SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 19.0.0.Final
    • None
    • MP Metrics
    • None

      SmallRye Metrics - JmxWorker - findKeyForValueToBeReplaced could use some polish

      https://github.com/smallrye/smallrye-metrics/blob/master/implementation/src/main/java/io/smallrye/metrics/JmxWorker.java#L156

      • iterate entrySet instead of keySet
      • can it happen that there are more entries with value '*' ?
      • shouldn't the for cycle end when the (first?) match is found ?

              jaslee@redhat.com Jason Lee
              rsvoboda@redhat.com Rostislav Svoboda
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: