Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-12739

Flash Scope is not cleared when JSF1095 is occurred

    XMLWordPrintable

Details

    • Hide

      1. Deploy leak2.war attached in this Jira.
      2. Access http://localhost:8080/leak2/
      3. Click "to Download" button
      4. Click repeatedly "Download". Click several times results in java.lang.OutOfMemory.

      Show
      1. Deploy leak2.war attached in this Jira. 2. Access http://localhost:8080/leak2/ 3. Click "to Download" button 4. Click repeatedly "Download". Click several times results in java.lang.OutOfMemory.
    • Hide

      If the response is already committed, do not use Flash Scope as the following code:

      try {
    // The response is committed by following code.
    // Therefore, mojarra can not set csfcfc Cookie to identify FlashScope.
    externalContext.responseFlushBuffer();
    facesContext.responseComplete();
} catch (Exception e) {
    e.printStackTrace();
}

if (!FacesContext.getCurrentInstance().getExternalContext().isResponseCommitted()) {
    Flash flash = FacesContext.getCurrentInstance().getExternalContext().getFlash();
    flash.put("business", businessMap);
}

      Flash Scope is a feature for holding scope during the POST-REDIRECT-GET design pattern. If the response is already committed in the action method and it does not respond REDIRECT, using Flash Scope is meaningless.

      Show
      If the response is already committed, do not use Flash Scope as the following code: try { // The response is committed by following code. // Therefore, mojarra can not set csfcfc Cookie to identify FlashScope. externalContext.responseFlushBuffer(); facesContext.responseComplete(); } catch (Exception e) { e.printStackTrace(); } if (!FacesContext.getCurrentInstance().getExternalContext().isResponseCommitted()) { Flash flash = FacesContext.getCurrentInstance().getExternalContext().getFlash(); flash.put( "business" , businessMap); } Flash Scope is a feature for holding scope during the POST-REDIRECT-GET design pattern. If the response is already committed in the action method and it does not respond REDIRECT, using Flash Scope is meaningless.

    Description

      If committing the response for file download processing and using Flash Scope in the action method are combined as the following code, the Flash Scope will not be cleared in subsequent requests.

      try {
    // The response is committed by following code.
    // Therefore, mojarra can not set csfcfc Cookie to identify FlashScope.
    externalContext.responseFlushBuffer();
    facesContext.responseComplete();
} catch (Exception e) {
    e.printStackTrace();
}

Flash flash = FacesContext.getCurrentInstance().getExternalContext().getFlash();
flash.put("business", businessMap);

      In other words, if the below log shows in server.log, the Flash Scope will not be cleared in subsequent requests.

      2019-10-28 10:38:09,180 WARNING [javax.enterprise.resource.webcontainer.jsf.flash] (default task-1) JSF1095: The response was already committed by the time we tried to set the outgoing cookie for the flash.  Any values stored to the flash will not be available on the next request.

      Attachments

        Issue Links

          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-17907 [GSS](7.3.z) Flash Scope is not cleared when JSF1095 is occurred

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Verified
          is incorporated by

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. WFLY-12799 Upgrade JSF based on Mojarra 2.3.9.SP04 to 2.3.9.SP05

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              spyrkob Bartosz Spyrko-Smietanko
              spyrkob Bartosz Spyrko-Smietanko
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: