Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-11124

The wildfly-testsuite-shared module brings in all WildFly dependencies

    XMLWordPrintable

Details

    Description

      The org.wildfly:wildfly-testsuite-shared has a dependency all the main 3 Galleon feature-packs.

      <dependency>
          <groupId>${project.groupId}</groupId>
          <artifactId>wildfly-galleon-pack</artifactId>
          <type>pom</type>
      </dependency>
      <dependency>
          <groupId>${project.groupId}</groupId>
          <artifactId>wildfly-servlet-galleon-pack</artifactId>
          <type>pom</type>
      </dependency>
      <dependency>
          <groupId>org.wildfly.core</groupId>
          <artifactId>wildfly-core-galleon-pack</artifactId>
          <type>pom</type>
      </dependency>
      

      This means that all tests that which use the shared module, likely all of them, end up with the entirety of WildFly on the test class path. In most cases this is not an issue. However an issue was uncovered with the IBM JDK in WFLY-10529. The tests should definitely not have a transitive dependency on things like that or for example the org.wildfly.core:wildfly-controller. If dependencies like those are needed they should be explicitly defined as those are not public API's.

      Attachments

        Issue Links

          Activity

            People

              jperkins-rhn James Perkins
              jperkins-rhn James Perkins
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: