Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-921

Remove n2 model node cloning in ServerOperationResolver

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 2.0.0.Beta5
    • 2.0.0.Beta4
    • Management
    • None

    Description

      ServerOperationResolver gets called for each operation in a composite.

      For each call it clones the configuration model.

      It then calls node.asPropertyList() in various spots, which in turn results in a clone of the value of each Property. In particular it does this over the profiles, which means each profile gets cloned.

      For very large configurations, this is extremely inefficient. One user was experimenting with adding 1000s of data sources and found it would take over an hour to complete the work. I was able to do it in 30 seconds by correcting these problems.

      There are other areas where we may be incurring unneeded expense via calls to node.asPropertyList().

      Attachments

        Issue Links

          is related to

          Bug - A problem that impairs or prevents the functions of the product. WFCORE-922 Remove unneeded cloning of model nodes when persisting the kernel configs

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Bug - A problem that impairs or prevents the functions of the product. WFLY-5234 Use of ModelNode.asPropertyList() is slow when marshaling potentially large subsystem model chunks

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) WFCORE-936 PersistentResourceXMLDescription & friends shouldn't use ModelNode#asPropertyList()

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Activity

            People

              bstansbe@redhat.com Brian Stansberry
              bstansbe@redhat.com Brian Stansberry
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: