Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-7100

Use a concurrent set for ModuleSpecification.userDependenciesSet

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 27.0.0.Beta7
    • None
    • Server
    • None

      WSClassVerificationProcessor in full WF misuses ModuleSpecfication by having a DUP for sub-deployment unit X iterate the user dependencies of X's parent and siblings. This sometimes fails with ConcurrentModificationException.

      It does this to fix a bug that which would reappear if we corrected that behavior, so let's just make this one collection thread safe.

      The WSClassVerificationProcessor behavior is still wrong because it assumes the data for X's parent and siblings are all complete when it reads them, and that is not guaranteed to be true; the parent and subdeployments proceed independently. But even that wrong behavior is less likely to give a bad result (issuing an unnecessary log WARN) than not trying at all.

              bstansbe@redhat.com Brian Stansberry
              bstansbe@redhat.com Brian Stansberry
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: