Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-7053

Enhance ResolveExpressionAttributesTestCase to test the resoution done by the server code

XMLWordPrintable

      ResolveExpressionAttributesTestCase tests that the XMl subsystem expressions can be resolved.

      Right now it is just using the ModelNode ValueExpression to resolve the expressions read from the XML subsystem markup under test.

      This is weak, because it is just testing that the ModelNode object is able to resolve expressions based on its ValueExpression. 

      It would be better if instead, the server is the one that resolves the subsystem expression based on its own logic (which could be the same as the current one being tested) and returns the ModelNode already resolved.

      By doing that, we will be testing how the server resolves this specific subsystem and not how just the ModelNode resolves it. That will make the test more robust to test server code changes.

       

      An example of this approach can be found at https://github.com/wildfly/wildfly/blob/main/naming/src/test/java/org/jboss/as/naming/subsystem/NamingSubsystemTestCase.java#L113-L117:

              final KernelServices services = createKernelServicesBuilder(createAdditionalInitialization()).setSubsystemXml(readResource("subsystem_expression.xml")).build();
              final ModelNode addr = Operations.createAddress("subsystem", "naming");
              final ModelNode op = Operations.createReadResourceOperation(addr, true);
              op.get(ModelDescriptionConstants.RESOLVE_EXPRESSIONS).set(true);
              final ModelNode result = services.executeOperation(op).get("result");

      There the resource is read with the expressions resolved.

       

              Unassigned Unassigned
              yborgess1@redhat.com Yeray Borges Santana
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: