Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-5606

Refactor resource closing

    XMLWordPrintable

Details

    • Task
    • Resolution: Won't Do
    • Major
    • None
    • 17.0.0.Final
    • None
    • None

    Description

      Currently some codepoints do a manual safe close without a util library, some code points have custom util methods. Some projects have dependencies to more than one util and use more than one. Some custom utils log the failure, some not. Some standard libraries have a trace on the attempt to close and on the failure, some not. Some close statements lack of proper error handling, some do not free the closed resource.

      Goal: Standardize the closing of resources, close all relevant resources and free them, properly reporting errors. Gain the possibility to trace potential resource leaks.
      java.io.Closeable requires a idempotent behaviour, java.lang.AutoCloseable recommends it.

      Current utilities in use:

      org.xnio.IoUtils.safeClose offers the most complete set of features:

      • Closeable, Closeable..., AutoCloseable
      • null check
      • trace the attempt to close
      • trace the error, if one occurs

      Attachments

        Issue Links

          relates to

          Sub-task - The sub-task of the issue WFCORE-5614 Refactor resource closing (cli)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5615 Refactor resource closing (controller)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5616 Refactor resource closing (deployment)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5617 Refactor resource closing (domain)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5618 Refactor resource closing (elytron)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5619 Refactor resource closing (host-controller)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5620 Refactor resource closing (logging)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5621 Refactor resource closing (management-client-content)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5622 Refactor resource closing (model-test)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5623 Refactor resource closing (patching)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5624 Refactor resource closing (process-controller)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5625 Refactor resource closing (protocol)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5626 Refactor resource closing (security-manager)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Sub-task - The sub-task of the issue WFCORE-5627 Refactor resource closing (server)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              xf01213 Boris Unckel (Inactive)
              xf01213 Boris Unckel (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: