Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-502

Eliminate requirement for OperationStepHandler.execute to call completeStep/stepCompleted

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 1.0.0.Alpha16
    • None
    • Management
    • None

      The requirement that an OSH call completeStep/stepCompleted in its execute method dates from when we supported recursive step execution. It could have been eliminated when we dropped support for recursive step execution, but that didn't occur to me until yesterday.

      All stepCompleted() does is register a default ResultHandler. AbstractOperationContext.executeStep could do the same thing after calling step.execute(...) if that call returns normally and it sees that no ResultHandler was registered with the step.

      Even I fairly often make the mistake of forgetting to add a stepCompleted call.

            bstansbe@redhat.com Brian Stansberry
            bstansbe@redhat.com Brian Stansberry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: