Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-4462

Restart level calculation in SimpleResourceDefinition.Parameters is ineffective.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • None
    • 8.0.0.Final, 9.0.0.Beta4
    • Management
    • None

      Parameters attempts to set a restart level for add or remove based on the type of the handler for the op:

          public Parameters setAddHandler(OperationStepHandler addHandler) {
                  this.addHandler = addHandler;
                  if (this.addRestartLevel == null) {
                      this.addRestartLevel = restartLevelForAdd(addHandler);
                  }
                  return this;
              }
      

      The problem is restartLevelForAdd(addHandler) doesn't get called because this.addRestartLevel and this.removeRestartLevel are initialized to non-null values.

      The effect of this is SimpleResourceDefinition impls that moved from passing multiple params to the constructor to instead passing a Parameters object have had the restart-level description of their add and remove ops changed.

      This is tricky because fixing this means some things may get changed back.

        1. full-ha-rrd-current.txt
          72.80 MB
        2. full-ha-rrd-wfcore-4462.txt
          72.80 MB
        3. microprofile-rrd-current.txt
          60.07 MB
        4. microprofile-rrd-wfcore-4462.txt
          60.07 MB

              bstansbe@redhat.com Brian Stansberry
              bstansbe@redhat.com Brian Stansberry
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: