Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-2314

Incorrectly closed header results in not helping IllegalArgumentException with null message

    XMLWordPrintable

Details

    Description

      Calling /core-service=management/security-realm=bbb:add(){allow-resource-service-restart=true) (notice incorrectly closed allow-resource-service-restart with ")" instead of "}" results in

      [standalone@localhost:9990 /] /core-service=management/security-realm=bbb:add(){allow-resource-service-restart=true)
      {
          "outcome" => "failed",
          "failure-description" => "java.lang.IllegalArgumentException:null"
      }
      

      with this message in server.log:

      14:20:12,440 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 10) WFLYCTL0403: Unexpected failure during execution of the following operation(s): [{
          "address" => [
              ("core-service" => "management"),
              ("security-realm" => "bbb")
          ],
          "operation" => "add",
          "operation-headers" => {
              "allow-resource-service-restart" => "true)",
              "caller-type" => "user",
              "access-mechanism" => "NATIVE"
          }
      }]: java.lang.IllegalArgumentException
      	at org.jboss.dmr.StringModelValue.asBoolean(StringModelValue.java:157)
      	at org.jboss.dmr.ModelNode.asBoolean(ModelNode.java:267)
      	at org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:346)
      	at org.jboss.as.controller.ModelControllerImpl.lambda$execute$1(ModelControllerImpl.java:240)
      	at org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:193)
      	at org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:240)
      	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:217)
      	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.access$400(ModelControllerClientOperationHandler.java:137)
      	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:161)
      	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:157)
      	at org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:212)
      	at org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:185)
      	at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:157)
      	at org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$1.doExecute(ManagementRequestContextImpl.java:70)
      	at org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$AsyncTaskRunner.run(ManagementRequestContextImpl.java:160)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      	at java.lang.Thread.run(Thread.java:745)
      	at org.jboss.threads.JBossThread.run(JBossThread.java:320)
      
      

      The IllegalArgumentException should point in the message what argument is incorrect and what is wrong. Printing only null doesn't help much.

      Attachments

        Issue Links

          Activity

            People

              bstansbe@redhat.com Brian Stansberry
              rhatlapa@redhat.com Radim Hatlapatka (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: