Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-1657

Confusing tab completion for adding a module dependencies

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 3.0.0.Alpha9
    • 3.0.0.Alpha3, 2.2.0.CR7
    • CLI
    • None

      Using tab completion for adding a module dependencies with module add command could lead to invalid module.xml as CLI prompt user to use module name with "system.layers.base" prefix, which is not a part of module name.

      reproduce
      Add a new module via module add command, use tab-completion for dependencies

      module add --name=<name> --resources=<path_to_jar> --dependencies=<TAB>
      module add --name=<name> --resources=<path_to_jar> --dependencies=system.<TAB>
      module add --name=<name> --resources=<path_to_jar> --dependencies=system.layers.<TAB>
      module add --name=<name> --resources=<path_to_jar> --dependencies=system.layers.base.<TAB>
      asm  ch  com  gnu  ibm  io  javaee  javax  net  nu  org  sun 
      

      this way something like following is generated in module.xml file

      <dependencies>
          <module name="system.layers.base.org.jboss.as.controller"/>
      </dependencies>
      

      however correct module name is org.jboss.as.controller

              spyrkob Bartosz Spyrko-Smietanko
              spyrkob Bartosz Spyrko-Smietanko
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: