Uploaded image for project: 'Weld'
  1. Weld
  2. WELD-949

Move firing of ContainerInitialized event from StartMain to the end of Weld.initialize()

    Details

      Description

      I suggest to move firing of ContainerInitialized event from StartMain to the end of Weld.initialize().

      Rationale:

      • Having this done by Weld.initialize() is more expectable (IMO) than having it restricted to a concrete class.
      • With the event fired from the end of initialize(), users who bootstrap Weld on their own would not need to introduce their own "startup", or worse, fire ContainerInitialized on their own.
      • Backward compatible - currently only StartMain() fires the event. In case of this change, firing would be removed from StartMain(), so the current behavior would not change. The only case when it would do harm is if user fired ContainerInitialized in their own code. Which they should not - such usage smells

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                alesj AleŇ° Justin
                Reporter:
                ozizka Ondrej Zizka
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: