Uploaded image for project: 'Weld'
  1. Weld
  2. WELD-2551

Interface default methods are treated inconsistently by AnnotatedType and WithAnnotations

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Minor
    • 3.1.0.Final
    • 3.0.5.Final
    • Extensions
    • None
    • Hide

      I have a class `MyBean` which implements an interface `MyInterface` and `MyInterface` declares a default method `myMethod()` which is annotated `@MyAnnotation`.

      If I observe the `ProcessAnnotatedType` event for `MyBean`, I can call `getAnnotatedType().getMethods()` and see the default method inherited from `MyInterface`.

      However, if I observe the `ProcessAnnotatedType` event but constrain it using `@WithAnnotations(MyAnnotation.class)`, my observer method is not called.

      Show
      I have a class `MyBean` which implements an interface `MyInterface` and `MyInterface` declares a default method `myMethod()` which is annotated `@MyAnnotation`. If I observe the `ProcessAnnotatedType` event for `MyBean`, I can call `getAnnotatedType().getMethods()` and see the default method inherited from `MyInterface`. However, if I observe the `ProcessAnnotatedType` event but constrain it using `@WithAnnotations(MyAnnotation.class)`, my observer method is not called.

    Description

      AnnotatedType.getMethods() returns default methods inherited from interfaces, but @WithAnnotations does not consider annotations on these methods when selecting types for the ProcessAnnotatedType event.

      The Javadoc for WithAnnotations seems to say it should be consistent with spec section 11.4. Alternative Metadata Sources which includes the description of AnnotatedType.getMethods().

      Section 11.4 only talks about methods from the class and its superclasses and makes no mention of default methods from interfaces.

      I'm not sure whether default methods inherited from interfaces should be included here, but I would expect AnnotatedType.getMethods() and WithAnnotations to be consistent.

      Attachments

        Issue Links

          is related to

          Bug - A problem that impairs or prevents the functions of the product. WFLY-11636 WeldClassFileInfo#containsAnnotation() should consider interface default methods

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed

          Activity

            People

              mkouba@redhat.com Martin Kouba
              azquelt Andrew Rouse
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: