Uploaded image for project: 'MicroShift'
  1. MicroShift
  2. USHIFT-4069

4.17 Rebase broken by gotemplating in MCO source yaml

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • None
    • openshift-4.17
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • 3
    • 3
    • None
    • None
    • None
    • uShift Sprint 258
    • None
    • None
    • None

      Description of problem:

      A recent update in the openshift/machine-config-operator to file templates/master/01-master-kubelet/_base/files/kubelet.yaml changed the array value of tlsCipherSuites field to a go template. After that, yq is unable to work on the data.

      Version-Release number of selected component (if applicable):

      main,4.17

      How reproducible:

      100%

      Steps to Reproduce:

      1. checkout release-4.17
      2. run ./scripts/auto-rebase/rebase.sh to "registry.ci.openshift.org/ocp/release:4.17.0-0.nightly-2024-08-13-031847" "registry.ci.openshift.org/ocp-arm64/release-arm64:4.17.0-0.nightly-arm64-2024-08-13-025544"

      Actual results:

      "Error: bad file '-': yaml: line 28: did not find expected node content"

      Expected results:

      yq should not fail

      Additional info:

      see mco breaking change here:
      https://github.com/openshift/machine-config-operator/commit/3b979e1ddf2a6e2c3e9b4a7872e31db888da1d57#diff-7e37987828daa82184819a87de503b6546be9a83519ff94f416447e4b3814d11

       

              jcope@redhat.com Jon Cope
              jcope@redhat.com Jon Cope
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: