Uploaded image for project: 'MicroShift'
  1. MicroShift
  2. USHIFT-3457

Release notes script does not log subcommand's stdout/stderr

XMLWordPrintable

    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • 3
    • uShift Sprint 255

      Description of problem:

      Release notes script does not log subcommand's stdout/stderr making it impossible to know why a command failed.
      
      For example, we know the command, we know it failed, we don't know why:
      
      GIT_COMMITTER_DATE=2024-06-07 14:11 git tag 4.16.0-rc.4-202406071411.p0 061ebb0
      Traceback (most recent call last):
        File "/go/src/github.com/openshift/microshift/scripts/release-notes/gen_ec_release_notes.py", line 615, in <module>
          main()
        File "/go/src/github.com/openshift/microshift/scripts/release-notes/gen_ec_release_notes.py", line 222, in main
          publish_release(new_release, not args.dry_run)
        File "/go/src/github.com/openshift/microshift/scripts/release-notes/gen_ec_release_notes.py", line 523, in publish_release
          tag_release(release_name, commit_sha, buildtime)
        File "/go/src/github.com/openshift/microshift/scripts/release-notes/gen_ec_release_notes.py", line 452, in tag_release
          subprocess.run(
        File "/usr/lib64/python3.9/subprocess.py", line 528, in run
          raise CalledProcessError(retcode, process.args,
      subprocess.CalledProcessError: Command '['git', 'tag', '-m', '4.16.0-rc.4-202406071411.p0', '4.16.0-rc.4-202406071411.p0', '061ebb0']' returned non-zero exit status 128.

      Version-Release number of selected component (if applicable):

       

      How reproducible:

      CI
      https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/periodic-ci-openshift-microshift-main-publish-release-notes/1800030377545306112/artifacts/publish-release-notes/openshift-microshift-publish-release-notes/build-log.txt

      Steps to Reproduce:

      1.
      2.
      3.
      

      Actual results:

      Stdout and stderr of subcommands are not logged

      Expected results:

      Stdout and stderr of subcommands are logged

      Additional info:

       

              pmatusza@redhat.com Patryk Matuszak
              pmatusza@redhat.com Patryk Matuszak
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: