Uploaded image for project: 'Undertow'
  1. Undertow
  2. UNDERTOW-557

Undertow missing jboss logging internationalization

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Blocker Blocker
    • 1.3.1.Final
    • None
    • None
    • None

      It is required for EAP7 to contain all features from EAP6.
      Per https://issues.jboss.org/browse/ANDIAMO-7, in EAP6 every serious log message (warn, error, fatal) should have a unique code that can be used to identify it.

      However, we found 45 serious log messages in EAP7.0.0.DR11 Undertow module without id.
      List of serious log messages without id from a smoke test (link to Jenkins run will be provided when the automated test case is finished):

        Suspicious logs: 45 
          	/servlet/src/main/java/io/undertow/servlet/handlers/ServletInitialHandler.java:311 dispatcher.error(servletRequestContext, request, response, servletChain.getManagedServlet().getServletInfo().getName(), t);
          	/servlet/src/main/java/io/undertow/servlet/spec/ServletContextImpl.java:317 UndertowServletLogger.ROOT_LOGGER.error(msg, exception);
          	/servlet/src/main/java/io/undertow/servlet/spec/ServletContextImpl.java:322 UndertowServletLogger.ROOT_LOGGER.error(message, throwable);
          	/servlet/src/main/java/io/undertow/servlet/spec/HttpServletResponseImpl.java:151 requestDispatcher.error(servletRequestContext, servletRequestContext.getServletRequest(), servletRequestContext.getServletResponse(), exchange.getAttachment(ServletRequestContext.ATTACHMENT_KEY).getCurrentServlet().getManagedServlet().getServletInfo().getName(), error);
          	/core/src/main/java/io/undertow/websockets/core/WebSocketUtils.java:332 WebSocketLogger.REQUEST_LOGGER.error("BUFFER HAS REMAINING!!!!!");
          	/core/src/main/java/io/undertow/protocols/http2/Http2Channel.java:410 UndertowLogger.REQUEST_IO_LOGGER.error("Buffer: " + sb.toString());
          	/core/src/main/java/io/undertow/server/handlers/JDBCLogHandler.java:218 UndertowLogger.ROOT_LOGGER.error(e);
          	/core/src/main/java/io/undertow/server/handlers/encoding/ContentEncodedResourceManager.java:142 UndertowLogger.REQUEST_LOGGER.error("Failed to write pre-cached file");
          	/core/src/main/java/io/undertow/server/Connectors.java:221 UndertowLogger.REQUEST_LOGGER.errorf(t, "Undertow request failed %s", exchange);
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:109 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:119 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:131 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:159 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:167 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:181 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:210 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:220 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:232 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:260 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:268 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/BlockingReceiverImpl.java:282 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:116 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:126 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:177 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:188 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:207 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:212 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:245 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:253 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:307 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:340 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:375 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:385 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:436 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:446 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:465 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:470 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:502 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:510 error.error(exchange, new RequestToLargeException());
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:563 error.error(exchange, e);
          	/core/src/main/java/io/undertow/io/AsyncReceiverImpl.java:598 error.error(exchange, e);
          	/core/src/test/java/io/undertow/testutils/DefaultServer.java:386 log.error("HTTP2 selected but Netty ALPN was not on the boot class path");
          	/core/src/test/java/io/undertow/testutils/DefaultServer.java:389 log.error("SPDY selected but Netty ALPN was not on the boot class path");
          	/websockets-jsr/src/test/java/io/undertow/websockets/jsr/test/autobahn/AnnotatedAutobahnServer.java:107 log.error("failed to start server", e);
          	/websockets-jsr/src/test/java/io/undertow/websockets/jsr/test/autobahn/AnnotatedAutobahnExtensionsServer.java:116 log.error("failed to start server", e);
      

      Giving blocker priority as this issue blocks RFE verification.

            sdouglas1@redhat.com Stuart Douglas
            mvinkler1@redhat.com Michal Vinkler
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: