Uploaded image for project: 'Undertow'
  1. Undertow
  2. UNDERTOW-2379

UndertowOptions default values need proper links and need to be used properly

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • None
    • None

      The code should use the public static final fields that define the constnat value of default value, instead of value being hardcoded.
      Example: https://github.com/undertow-io/undertow/blob/master/core/src/main/java/io/undertow/server/handlers/form/FormEncodedDataDefinition.java#L111 - direct input, rather than dependency on default value defined in https://github.com/undertow-io/undertow/blob/master/core/src/main/java/io/undertow/UndertowOptions.java#L84

      this.data = new FormData(exchange.getConnection().getUndertowOptions().get(UndertowOptions.MAX_PARAMETERS, 1000));
      

      It should be using the value defined in https://github.com/undertow-io/undertow/blob/main/core/src/main/java/io/undertow/UndertowOptions.java#L84 instead:

      public static final int DEFAULT_MAX_PARAMETERS = 1000;
      

      Also, the Javadoc in UndertowOptions needs fixing, it has the numeric value, rather than proper link with @link

          1.
          Verify usage of UndertowOptions.DEFAULT_READ_TIMEOUT with UndertowOptions.READ_TIMEOUT and IDLE_TIMEOUT Sub-task Open Major Unassigned
          2.
          Verify usage of UndertowOptions.DEFAULT_MAX_HEADER_SIZE with UndertowOptions.MAX_HEADER_SIZE Sub-task Open Major Unassigned
          3.
          Verify usage of UndertowOptions.DEFAULT_MAX_ENTITY_SIZE with UndertowOptions.MAX_ENTITY_SIZE Sub-task Open Major Unassigned
          4.
          Verify usage of UndertowOptions.DEFAULT_MAX_COOKIES with UndertowOptions.MAX_COOKIES Sub-task Open Major Unassigned
          5.
          Create a default constant for UndertowOptions.ALLOW_ENCODED_HASH Sub-task Pull Request Sent Major Bartosz Baranowski
          6.
          Create a default constant for UndertowOptions.DECODE_SLASH Sub-task Open Major Unassigned
          7.
          Create a default constant for UndertowOptions.DECODE_URL Sub-task Open Major Unassigned
          8.
          Fix UndertowOptions.URL_CHARSET Javadoc Sub-task Open Major Unassigned
          9.
          Create a default constant for UndertowOptions.ALWAYS_SET_KEEP_ALIVE Sub-task Open Major Unassigned
          10.
          Create a default constant for UndertowOptions.ALWAYS_SET_DATE Sub-task Open Major Unassigned
          11.
          Verify usage of UndertowOptions.DEFAULT_MAX_BUFFERED_REQUEST_SIZE with UndertowOptions.MAX_BUFFERED_REQUEST_SIZE Sub-task Open Major Unassigned
          12.
          Create a default constant for UndertowOptions.RECORD_REQUEST_START_TIME Sub-task Open Major Unassigned
          13.
          Create a default constant for UndertowOptions.ALLOW_EQUALS_IN_COOKIE_VALUE Sub-task Open Major Unassigned
          14.
          Verify usage of UndertowOptions.DEFAULT_ENABLE_RFC6265_COOKIE_VALIDATION with UndertowOptions.ENABLE_RFC6265_COOKIE_VALIDATION Sub-task Open Major Unassigned
          15.
          Mark UndertowOptions.ENABLE_SPDY for removal Sub-task Open Major Flavia Rainone
          16.
          Create a default constant for UndertowOptions.ENABLE_HTTP2 Sub-task Open Major Unassigned
          17.
          Create a default constant for UndertowOptions.ENABLE_STATISTICS Sub-task Open Major Unassigned
          18.
          Mark UndertowOptions.ENABLE_CONNECTOR_STATISTICS for removal Sub-task Coding In Progress Major Flavia Rainone
          19.
          Create a default constant for UndertowOptions.ALLOW_UNKNOWN_PROTOCOLS Sub-task Open Major Unassigned
          20.
          Verify usage of UndertowOptions.HTTP2_SETTINGS_HEADER_TABLE_SIZE_DEFAULT with UndertowOptions.HTTP2_SETTINGS_HEADER_TABLE_SIZE Sub-task Open Major Unassigned
          21.
          Create UndertowOptions.DEFAULT_HTTP2_SETTINGS_HEADER_TABLE_SIZE and deprecate current default field Sub-task Open Major Unassigned
          22.
          Create a default constant for UndertowOptions.HTTP2_SETTINGS_ENABLE_PUSH Sub-task Open Major Unassigned
          23.
          Verify usage of UndertowOptions.DEFAULT_HTTP2_SETTINGS_MAX_CONCURRENT_STREAMS with UndertowOptions.HTTP2_SETTINGS_MAX_CONCURRENT_STREAMS Sub-task Open Major Unassigned
          24.
          Create a default constant for UndertowOptions.HTTP2_SETTINGS_INITIAL_WINDOW_SIZE Sub-task Coding In Progress Major Flavia Rainone
          25.
          Create a default constant for UndertowOptions.HTTP2_SETTINGS_MAX_FRAME_SIZE Sub-task Open Major Unassigned
          26.
          Mark UndertowOptions.HTTP2_SETTINGS_MAX_HEADER_LIST_SIZE for removal Sub-task Coding In Progress Major Flavia Rainone
          27.
          Create a default constant for UndertowOptions.HTTP2_PADDING_SIZE Sub-task Open Major Unassigned
          28.
          Create a default constant for UndertowOptions.MAX_QUEUED_READ_BUFFERS Sub-task Open Major Unassigned
          29.
          Create a default constant for UndertowOptions.MAX_AJP_PACKET_SIZE Sub-task Open Major Unassigned
          30.
          Create a default constant for UndertowOptions.REQUIRE_HOST_HTTP11 Sub-task Open Major Unassigned
          31.
          Verify usage of UndertowOptions.DEFAULT_MAX_CACHED_HEADER_SIZE with UndertowOptions.MAX_CACHED_HEADER_SIZE Sub-task Open Major Unassigned
          32.
          Verify usage of UndertowOptions.DEFAULT_HTTP_HEADERS_CACHE_SIZE with UndertowOptions.HTTP_HEADERS_CACHE_SIZE Sub-task Open Major Unassigned
          33.
          Create a default constant for UndertowOptions.HTTP_HEADERS_CACHE_SIZE Sub-task Open Major Unassigned
          34.
          Create a default constant for UndertowOptions.SSL_USER_CIPHER_SUITES_ORDER Sub-task Open Major Unassigned
          35.
          Create a default constant for UndertowOptions.ALLOW_UNESCAPED_CHARACTERS_IN_URL Sub-task Open Major Unassigned
          36.
          Create a default constant for UndertowOptions.ENDPOINT_IDENTIFICATION_ALGORITHM Sub-task Open Major Unassigned
          37.
          Create a default constant for UndertowOptions.QUEUED_FRAMES_HIGH_WATER_MARK Sub-task Open Major Unassigned
          38.
          Create a default constant for UndertowOptions.QUEUED_FRAMES_LOW_WATER_MARK Sub-task Coding In Progress Major Flavia Rainone
          39.
          Verify usage of UndertowOptions.DEFAULT_RST_FRAMES_TIME_WINDOW with UndertowOptions.RST_FRAMES_TIME_WINDOW Sub-task Open Major Unassigned
          40.
          Verify usage of UndertowOptions.DEFAULT_MAX_RST_FRAMES_PER_WINDOW with UndertowOptions.MAX_RST_FRAMES_PER_WINDOW Sub-task Open Major Unassigned
          41.
          Verify all constants in UndertowOptions that are not currently used Sub-task Open Major Flavia Rainone

              Unassigned Unassigned
              rhn-cservice-bbaranow Bartosz Baranowski
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: