Uploaded image for project: 'Undertow'
  1. Undertow
  2. UNDERTOW-2305

NPE from Http2ClearClientProvider#createSettingsFrame()

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • 2.3.9.Final, 2.2.27.Final
    • 2.3.8.Final, 2.3.7.SP2
    • None
    • None

      See JBEAP-25508 for reproduction steps.

      There is probably a typo in:

                  if (options.contains(UndertowOptions.HTTP2_SETTINGS_MAX_HEADER_LIST_SIZE)) {
                pushOption(currentBuffer, Http2Setting.SETTINGS_MAX_HEADER_LIST_SIZE, options.get(UndertowOptions.HTTP2_SETTINGS_MAX_HEADER_LIST_SIZE));
            } else if(options.contains(UndertowOptions.MAX_HEADER_SIZE)) {
                pushOption(currentBuffer, Http2Setting.SETTINGS_MAX_HEADER_LIST_SIZE, options.get(UndertowOptions.HTTP2_SETTINGS_MAX_HEADER_LIST_SIZE));
            }

      The second options.get(UndertowOptions.HTTP2_SETTINGS_MAX_HEADER_LIST_SIZE) should likely use MAX_HEADER_SIZE instead of HTTP2_SETTINGS_MAX_HEADER_LIST_SIZE.

            thofman Tomas Hofman
            thofman Tomas Hofman
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: