Loading...

XML

Word

Printable

Type: Bug
Resolution: Done
Priority: Blocker
Fix Version/s: 2.2.26.Final, 2.3.8.Final, 2.2.25.SP2, 2.3.7.SP1
Affects Version/s: 2.3.6.Final
Component/s: Core
Labels:
None

Steps to Reproduce:
Hide

Download latest version of the h2spec TS - https://github.com/summerwind/h2spec/releases/tag/v2.6.0

extract it

start the JBoss EAP/WildFly server with default configuration ./bin/standalone.sh

start the TS: ./h2spec -h localhost -t -k -p 8443 http2/8
Show
Download latest version of the h2spec TS - https://github.com/summerwind/h2spec/releases/tag/v2.6.0 extract it start the JBoss EAP/WildFly server with default configuration ./bin/standalone.sh start the TS: ./h2spec -h localhost -t -k -p 8443 http2/8
Git Pull Request:
https://github.com/undertow-io/undertow/pull/1498, https://github.com/undertow-io/undertow/pull/1499, https://gitlab.cee.redhat.com/undertow-io/undertow/-/commit/84bf652c11da26018bcf3ebc9d596469ec7757ea, https://gitlab.cee.redhat.com/undertow-io/undertow/-/commit/cdd5355519d06789ed44b3e94a89f795c2a952af

With recent nightly builds of JBoss EAP (and WildFly too) we can see failures of 2 negative tests in the h2spec TS we use to check that JBoss EAP/WildFly/Undertow behaves according to the HTTP2 protocol standard.

Here are the failing tests:

Hypertext Transfer Protocol Version 2 (HTTP/2)
  8. HTTP Message Exchanges
    8.1. HTTP Request/Response Exchange
      × 1: Sends a second HEADERS frame without the END_STREAM flag
        -> The endpoint MUST respond with a stream error of type PROTOCOL_ERROR.
           Expected: GOAWAY Frame (Error Code: PROTOCOL_ERROR)
                     RST_STREAM Frame (Error Code: PROTOCOL_ERROR)
                     Connection closed
             Actual: DATA Frame (length:1504, flags:0x01, stream_id:1)

      8.1.2. HTTP Header Fields
        8.1.2.1. Pseudo-Header Fields
          × 3: Sends a HEADERS frame that contains a pseudo-header field as trailers
            -> The endpoint MUST respond with a stream error of type PROTOCOL_ERROR.
               Expected: GOAWAY Frame (Error Code: PROTOCOL_ERROR)
                         RST_STREAM Frame (Error Code: PROTOCOL_ERROR)
                         Connection closed
                 Actual: DATA Frame (length:1504, flags:0x01, stream_id:1)

What these two tests do is they simulate misbehaving client that breaks the HTTP2 protocol and server is supposed to end the connection with the client with PROTOCOL_ERROR code. But in our case the server happily continues with the DATA frame instead.

After some checks I found out that it was brought in by changes that were implemented for the ~~UNDERTOW-2258~~ issue - this PR and specifically this particular commit is the culprit that these two tests started to fail.

My assumption is that part of the code that sends the PROTOCOL_ERROR shouldn't have been removed completely but should have been kept there under some extra condition?

clones

JBEAP-24971 Undertow HTTP2 breaks protocol specification when client misbehaves

Closed

is caused by

UNDERTOW-2258 Http2ClientConnection does not handle continue responses properly

Closed

is incorporated by

WFCORE-6468 Upgrade Undertow to 2.3.8.Final

Resolved

Assignee:: Flavia Rainone

Reporter:: Jan Stourac

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 2023/06/09 12:40 PM

Updated:: 2023/08/17 9:12 AM

Resolved:: 2023/06/27 3:07 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates