Uploaded image for project: 'Undertow'
  1. Undertow
  2. UNDERTOW-2035

Http2StreamSinkChannel overrides awaitWritable() but does not override awaitWritable(long, TimeUnit)

XMLWordPrintable

    The class fails to follow the basic contract. If a awaitWritable method is overidden with added logic, all overloaded awaitWritable methods should be overridden as well so that the same added logic applies to all of them consistently.

    For future references XNIO SuspendableWriteChannel defines two awaitWritable methods:

    https://github.com/xnio/xnio/blob/3.8.6.Final/api/src/main/java/org/xnio/channels/SuspendableWriteChannel.java#L80

    and

    https://github.com/xnio/xnio/blob/3.8.6.Final/api/src/main/java/org/xnio/channels/SuspendableWriteChannel.java#L93

    While Http2StreamSinkChannel overrides just one of them:

    https://github.com/undertow-io/undertow/blob/2.2.16.Final/core/src/main/java/io/undertow/protocols/http2/Http2StreamSinkChannel.java#L181

          flaviarnn Flavia Rainone
          flaviarnn Flavia Rainone
          Brad Maxwell, David Lloyd, Flavia Rainone, Grzegorz Grzybek, Jason Lee, Joerg Baesner, Kunjan Rathod (Inactive), Masafumi Miura, Richard Opalka, Rodrigo Freire, Stefano Maestri, Stuart Douglas
          Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

            Created:
            Updated:
            Resolved: