Uploaded image for project: 'Undertow'
  1. Undertow
  2. UNDERTOW-2035

Http2StreamSinkChannel overrides awaitWritable() but does not override awaitWritable(long, TimeUnit)

    XMLWordPrintable

Description

    The class fails to follow the basic contract. If a awaitWritable method is overidden with added logic, all overloaded awaitWritable methods should be overridden as well so that the same added logic applies to all of them consistently.

    For future references XNIO SuspendableWriteChannel defines two awaitWritable methods:

    https://github.com/xnio/xnio/blob/3.8.6.Final/api/src/main/java/org/xnio/channels/SuspendableWriteChannel.java#L80

    and

    https://github.com/xnio/xnio/blob/3.8.6.Final/api/src/main/java/org/xnio/channels/SuspendableWriteChannel.java#L93

    While Http2StreamSinkChannel overrides just one of them:

    https://github.com/undertow-io/undertow/blob/2.2.16.Final/core/src/main/java/io/undertow/protocols/http2/Http2StreamSinkChannel.java#L181

    Attachments

      Issue Links

        is incorporated by

        Component Upgrade - A task tracking an update to a bundled component WFCORE-6057 Upgrade Undertow to 2.3.0.Final (CVE-2022-2764)

        • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
        • Resolved

        Component Upgrade - A task tracking an update to a bundled component WFCORE-5946 Upgrade Undertow to 2.2.18.Final

        • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
        • Resolved
        is related to

        Enhancement - An enhancement or refactoring of existing functionality UNDERTOW-2039 Convert AbstractFramedChannel.AWAIT_WRITABLE_TIMEOUT to nanoseconds

        • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
        • Open

        Activity

          Public project attachment banner

            context keys: [headless, issue, helper, isAsynchronousRequest, project, action, user]
            current Project key: UNDERTOW

            People

              flaviarnn Flavia Rainone
              flaviarnn Flavia Rainone
              Brad Maxwell, David Lloyd, Flavia Rainone, Grzegorz Grzybek, Jason Lee, Joerg Baesner, Kunjan Rathod (Inactive), Masafumi Miura, Richard Opalka, Rodrigo Freire, Stefano Maestri, Stuart Douglas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: