Uploaded image for project: 'Undertow'
  1. Undertow
  2. UNDERTOW-1224

ParseTimeoutUpdater and concurrency

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 2.0.0.Beta1, 1.4.22.Final
    • 1.4.11.Final
    • Core
    • None

      I think I found a possible threading issue with the ParseTimeoutUpdater.java class. Specifically, care was taken to mark certain fields in the class as volatile. The field ‘parsing’ is not marked as volatile and does appear to be used in a concurrent manner. I think simply making it volatile will at least resolve the liveliness of the data. This assumes the class doesn’t care about atomic operations on sets of related fields. This too may want to be reviewed.

      Regards,

      Bradley

      Affects multiple versions. Probably goes way back. I just listed a few affected versions.

      https://github.com/undertow-io/undertow/blob/1.4.11.Final/core/src/main/java/io/undertow/server/protocol/ParseTimeoutUpdater.java

      https://github.com/undertow-io/undertow/blob/1.4.20.Final/core/src/main/java/io/undertow/server/protocol/ParseTimeoutUpdater.java

      https://github.com/undertow-io/undertow/blob/master/core/src/main/java/io/undertow/server/protocol/ParseTimeoutUpdater.java

              sdouglas1@redhat.com Stuart Douglas (Inactive)
              blongstreth Bradley Longstreth (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: