Our customer is falsely notified via email that their credit card is about to Expire

A 3scale customer has received an email indicating their Credit card is about to expire even though the card's expiration is well into the future.

See this comment

Dev Notes 2

This is about the customer paying 3scale, not about their customers paying them. We didn't understand that when we estimated the first time. Let's estimate again

Customer account: https://multitenant-admin.3scale.net/buyers/accounts/2445581326492

Dev Notes 1
To reproduce - would have to do it in the console. This is complicated.
This could be a problem when there are multiple cards - the payment provider could have 2 or more cards stored in the payment vault. But we only record in our database 1 card (which happens to be the old one)

May be the same issue as THREESCALE-250, we need to check if it is still happening

Solution

Do not use the credit_card_expires_on column in accounts anymore

About the issue this customer is having, it is because we have a column in Account that should be deleted and the query should not use this column anymore.

The column is credit_card_expires_on
Sadly the value inside it is an old value Wed, 01 Apr 2020 ... which triggers the email to be sent

https://github.com/3scale/porta/blob/b6cf252359794438703db8628cf68f3d5c651d65/app/models/account/credit_card.rb#L14