Uploaded image for project: 'Red Hat 3scale API Management'
  1. Red Hat 3scale API Management
  2. THREESCALE-6529

Fix country format/code incompatibility in stripe

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a Bug
    • Icon: Major Major
    • None
    • None
    • None
    • None
    • False
    • False
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Undefined

      Use stripe-3ds2-base-branch as the base branch. See that in https://github.com/3scale/porta/blob/f1143d19f4664285fe5e5855774bb7c59e516365/app/views/payment_gateways/_stripe_elements.html.erb#L130 the country code is hardcoded. This is because we use to make the clients enter a country name and that was compatible with stripe before, but this new API endpoint only allows countries as ISO 3166-1 alpha-2 codes.

      So I hardcoded 'ES' to bypass this error message:

      But of course, we must fix the problem for real instead of ignoring it like that.

      To test it locally, besides following the instructions in the PDF in the Epic, first make sure that you have the rolling update stripe_elements: true or add it yourself in your config/rolling_updates.yml

        1. spain not iso-3166 code.png
          spain not iso-3166 code.png
          66 kB

            [THREESCALE-6529] Fix country format/code incompatibility in stripe

            Marta Noya (Inactive) added a comment -

            It turned out that it was not a bug. There is supposed to be a dropdown of countries to choose from in the billing address form and then its value is the 2 characters code. But that only pops up when the database is populated with countries. So I only had to run the rake task for it: bundle exec rake countries:import

            Marta Noya (Inactive) added a comment - It turned out that it was not a bug. There is supposed to be a dropdown of countries to choose from in the billing address form and then its value is the 2 characters code. But that only pops up when the database is populated with countries. So I only had to run the rake task for it: bundle exec rake countries:import

              Unassigned Unassigned
              mnoyabon Marta Noya (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: