Details
-
Bug
-
Resolution: Done
-
Critical
-
None
-
2.7 GA, SaaS
-
None
-
3
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
- Update the integration for a service
- Navigate to configuration history
- Download latest configuration file
- Search for querystring_parameters - it doesn't exist
-
3scale 2020-02-03, 3scale 2020-02-17
Description
Expected behaviour
When downloading a proxy config for APIcast it includes a field called querystring_parameters.
Current behaviour
Proxy config is missing querystring_parameters field. This is problematic for APIcast and routing requests based on mapping rules with query parameters.
Dev note
We now override, in [1][2], the template for the proxy rule objects that we include into the json proxy config. We used to have [3] before APIAP.
The fix should be simple. Merge the options of [3] into [2]. In order to DRY, I'd recommend refactoring [3] so it uses whatever is in [2], instead defining another template that may end up being replaced as in [1].
[1] https://github.com/3scale/porta/blob/79c438336f1a845c764030e3cc11c1302becbb7a/app/services/apicast_v2_deployment_service.rb#L26
[2] https://github.com/3scale/porta/blob/79c438336f1a845c764030e3cc11c1302becbb7a/app/lib/apicast/proxy_rules_source.rb#L20
[3] https://github.com/3scale/porta/blob/79c438336f1a845c764030e3cc11c1302becbb7a/app/lib/apicast/provider_source.rb#L28-L32