-
Task
-
Resolution: Unresolved
-
Major
-
None
-
None
-
None
-
False
-
-
False
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
-
While working on cucumber steps, I noticed that the steps for session management (log in, log out) are quite confusing, with some steps mixing buyer and provider workflows, some steps that are somewhat duplicated.
Also there are some steps that don't makes sense (at least the name), like "the buyer logs in to the provider" - this is just not something that happens.
In order to improve the steps and reduce confusing I suggest to refactor them.
Developer notes:
- in the step Then "(I )(they )should not be logged in" do consider adding /p/signup and signup to the list of paths.
- Avoid using `step` method, and just use helper methods instead.
- Consider if it makes sense renaming current_user variable to logged_user or session_user to make the intent more clear.