Uploaded image for project: 'Red Hat 3scale API Management'
  1. Red Hat 3scale API Management
  2. THREESCALE-10454

Refactor application controllers and make application name required always

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Optional Optional
    • None
    • None
    • System
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Not Started

      There is an old hack coming back from the days where the application (cinstance) name was not required.

      Validation for application name presence takes place only when "human edition" is detected - which is creating/editing applications via UI or API (see validation)

      It depends on @validate_human_edition being set (which is set in controllers).

      The proposal is to remove this confusing logic and make application *name* required always.

      It seems that one scenario where name should *not* be validated is when plan change is requested for applications that initially didn't have a name.
      There shouldn't be many of these, as this was only allowed on services where multiple applications were not allowed. And at some point even in this case we started generating a default application name. I think on-premises shouldn't be affected (but we'd need to check).

      I bet most of applications with no name in SaaS are already NOT in use, so probably they will never be updated (and thus it doesn't matter if they pass validation or not). But we can backfill them with some default-generated name.

              Unassigned Unassigned
              rhn-support-dmayorov Daria Mayorova
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: