Uploaded image for project: 'Teiid Designer'
  1. Teiid Designer
  2. TEIIDDES-2260

Teiid Designer doesn't clean up vdb.xml properly (Data Roles - conditions)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • 8.5.1, 8.3.4, 8.6
    • 8.3.3
    • VDB & Execution
    • None

      I don't know if it is a bug or there is some reason for that.

      When I create a condition for Data Role(& Save VDB) and then remove the condition(& Save VDB) Teiid Designer doesn't delete whole <permission> tag only the <condition> tag

      For example:
      Before removing

      <permission>
      <resource-name>Products_view.PRODUCTDATA</resource-name>
      <condition constraint="true">ISAMEXINT=1</condition>
      </permission>

      After removing:

      <permission>
      <resource-name>Products_view.PRODUCTDATA</resource-name>
      </permission>

      In my opinion Teiid Designer should delete whole <permission> tag and leave nothing behind..

            [TEIIDDES-2260] Teiid Designer doesn't clean up vdb.xml properly (Data Roles - conditions)

            RH Bugzilla Integration added a comment -

            Debi Rieden <drieden@redhat.com> changed the Status of bug 1122470 from VERIFIED to CLOSED

            RH Bugzilla Integration added a comment - Debi Rieden <drieden@redhat.com> changed the Status of bug 1122470 from VERIFIED to CLOSED

            RH Bugzilla Integration added a comment -

            Matus Makovy <mmakovy@redhat.com> changed the Status of bug 1122470 from MODIFIED to VERIFIED

            RH Bugzilla Integration added a comment - Matus Makovy <mmakovy@redhat.com> changed the Status of bug 1122470 from MODIFIED to VERIFIED

            RH Bugzilla Integration added a comment -

            Van Halbert <vhalbert@redhat.com> changed the Status of bug 1122470 from NEW to MODIFIED

            RH Bugzilla Integration added a comment - Van Halbert <vhalbert@redhat.com> changed the Status of bug 1122470 from NEW to MODIFIED

            Barry LaFond added a comment -

            Done
            https://github.com/Teiid-Designer/teiid-designer/commit/48556cb1b57120179a8ecdcbf232036b3733f453
            https://github.com/Teiid-Designer/teiid-designer/commit/120aa939598048c180e45253414c2bfefe13332f
            https://github.com/Teiid-Designer/teiid-designer/commit/d03e43f8c1f24d86f2d6b7ce2fa32b5475dc9162

            Barry LaFond added a comment - Done https://github.com/Teiid-Designer/teiid-designer/commit/48556cb1b57120179a8ecdcbf232036b3733f453 https://github.com/Teiid-Designer/teiid-designer/commit/120aa939598048c180e45253414c2bfefe13332f https://github.com/Teiid-Designer/teiid-designer/commit/d03e43f8c1f24d86f2d6b7ce2fa32b5475dc9162

            Matus Makovy added a comment -

            ...it should delete the <permission> tag in case it has only <resource-name> tag in it

            Matus Makovy added a comment - ...it should delete the <permission> tag in case it has only <resource-name> tag in it

              blafond Barry LaFond
              mmakovy@redhat.com Matus Makovy
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: