Uploaded image for project: 'Teiid'
  1. Teiid
  2. TEIID-2411

Add schema name to metadata validation messages

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Done
    • Major
    • 8.3
    • 8.2
    • Query Engine
    • Low

    Description

      Currently metadata validation messages don't contain schema name, so when working with lot of schemas it may be difficult to find out problematic element. For example, if table SOME_TABLE has no columns then
      org.teiid.query.metadata.MetadataValidator.MinimalMetadata.execute() will log following error message:
      TEIID31071 Invalid table; Table SOME_TABLE has no columns defined
      And there's no ability to detect later to which schema problematic table belongs.

      I suggest to append schema name - either by simple concatenation in MetadataValidator.java:

      metadataValidator.log(report, model, QueryPlugin.Util.gs(QueryPlugin.Event.TEIID31071, scmena.getName()+"."+t.getName()));

      or by changing message bundle i18n.properties:

      TEIID31071=Invalid table; Table

      {0}

      .

      {1}

      has no columns defined

      and providing message parameters in MetadataValidator.java:

      metadataValidator.log(report, model, QueryPlugin.Util.gs(QueryPlugin.Event.TEIID31071, scmena.getName(), t.getName()));

      There are also another validation messages in MetadataValidator.java which could be improved in similar way.

      Attachments

        Activity

          People

            rhn-engineering-rareddy Ramesh Reddy
            paul.lysak_jira Paul Lysak (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: