Uploaded image for project: 'Subscription Watch'
  1. Subscription Watch
  2. SWATCH-643

Change tally usage collection to map by org instead of account

    XMLWordPrintable

Details

    • Story
    • Resolution: Done
    • Blocker
    • None
    • None
    • None

    Description

      DONE:

      • Neither nightly tally nor hourly tally processes use accountNumber in any meaningful way (i.e. they should continue to populate accountNumber in the DB if present, but otherwise should not reference/use accountNumber).
      • Nightly tally can be performed against an account without account number
      • Hourly tally can be performed against an account without account number

      Replace the methods that uses account number with orgId for usage calculation.

      The natural endpoint for this is TallySnapshotController. This involves swapping accountNumber for orgId, and will additionally touch the following classes/methods (non-exhaustive):

      • MaxSeenSnapshotStrategy
      • AccountUsageCalculation
      • MetricUsageCollector
      • InventoryAccountUsageCollector
      • CombiningRollupSnapshotStrategy.produceSnapshotsFromCalculations
      • TallySnapshotRepository.findByAccountNumberAndProductIdInAndGranularityAndSnapshotDateBetween

      QE:

      • Nightly tally on an account without account_number should succeed and results should be visible via Tally API
      • Hourly tally on an account without account_number should succeed and results should be visible via Tally API

       

      Attachments

        Activity

          People

            mstead@redhat.com Michael Stead
            karshah@redhat.com Kartik Shah
            Nikhil Kathole Nikhil Kathole
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: