-
Task
-
Resolution: Unresolved
-
Major
-
None
-
None
-
None
-
False
-
-
False
-
subs-swatch-lightning
-
-
Our stage tests caught a regression (see slack thread for details), but there were no other (unit, integration, or component) tests that failed because of it. It's fantastic that the stage tests caught it, but the regression wasn't unique to the stage and could be recreated in local and ephemeral environments. We want to catch regressions as early in the development process as possible. Our Konflux pipelines are robust enough now that if there is a unit, component, or integration test failing - the PR checks would have failed and this would have likely been resolved before the PR was merged (subsequently landing in stage).
This card is to evaluate the following two tests, and determine if they could be rewritten as component/integration test(s) instead.
- test_verify_contract_adjustment_for_remove_contract
- test_verify_contract_adjustment_when_add_more_contract_in_mid_month
Acceptance Criteria
- Add unit, component and/or integration test coverage that would have caught the regression from the slack thread
- If the stage test is not providing any additional value by running in stage, remove it from the stage test suite.