While adding DAILY granularity TallySummaries the following was discovered in SnapshotSummaryProducer.produceTallySummaryMessages:

• HOURLY snapshots
  • The snapshots are passed in, any TOTAL measurements are removed from the passed objects, and the measurements are mapped into the Summary message.
  • IQE tests (i.e., test_verify_ansible_payg_usage) will fail if snapshots are cloned for use in the summaries and the total measurements are left in the original snapshot objects.
• DAILY snapshots (Newly added)
  • The snapshots are passed in, the object is cloned, the TOTAL measurements are removed from the cloned objects, and the measurements are mapped into the Summary message.
  • If the measurement removal happens on the original object (no clone), the IQE tests will fail because of it (i.e., test_tally_rhel_addons_variants).
• Questions
  • What is the point of having the TOTAL measurements on the snapshot objects?
  • Are the snapshots only altered in memory, or are they re-persisted without the TOTAL measurements? Should the snapshot entities be disassociated for this process?
  • Should we explicitly remove them elsewhere (outside of the summary production process) in a more intentional way only when necessary?
  • Should the mapper that creates the Summaries leave the TOTAL measurements out instead of altering the snapshot objects?

After answering these questions, we need a designed, uniform means for handling these measurements based on the use of the data.