-
Bug
-
Resolution: Done
-
Major
-
None
-
None
-
False
-
-
False
-
-
The semantics around running total measurements on /tally/products/{product_id} calls need to be clarified. Right now we are returning a record for every day in the time-span requested and marking days that don't have an associated measurement with has_data=false. This doesn't really make sense with a running total since even if we don't have a measurement, we still do still have data. Additionally, we shouldn't be returning future days since those would show the running total and we don't want to project that into the future.
The same sort of logic should be applied in https://github.com/RedHatInsights/rhsm-subscriptions/blob/76d4b11621d15380d08f162e6df3342a9683f06d/src/main/java/org/candlepin/subscriptions/tally/filler/TallyReportDataPointAdapter.java#L35 : hasData should be set to true for all dates including today's date and no dates beyond today should be returned.