-
Story
-
Resolution: Done
-
Undefined
-
None
-
None
-
None
There are some generated CRD's under config/crd/bases
https://github.com/openshift/local-storage-operator/tree/master/config/crd/bases
But those are A) never updated by any Makefile targets, and B) never used when generating the bundle.
https://github.com/openshift/local-storage-operator/blob/master/config/bundle.Dockerfile
Instead, the bundle uses these CRD's which are updated manually?
https://github.com/openshift/local-storage-operator/tree/master/config/manifests/stable
We can do better.
- generate CRD's from API using controller-gen
- add 'make update' and 'make verify' targets
- remove the manually updated CRD's in config/manifests/stable
- update bundle.Dockerfile to include the generated CRD's
- remove manifests that are clearly not used anywhere, it's confusing to figure out what needs to be updated and what is just dead code.
- add 'verify' to presubmit jobs for LSO