Uploaded image for project: 'Knative Serving'
  1. Knative Serving
  2. SRVKS-832

KnativeServing sets Kourier "enabled: false" when oc edit knativeserving spec.ingress

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • 1.19.0
    • None
    • Operator

      When KnativeService.Spec.Ingress is modified by oc edit, it fills Kourier.Enabled to false.

      Example 1. Set Kourier.service-type to LoadBalancer

      spec:
  ingress:
    kourier:
      service-type: LoadBalancer

      It will be changed as:

        ingress:
    contour:
      enabled: false
    istio:
      enabled: false
    kourier:
      enabled: false
      service-type: LoadBalancer

      Example 2. Set Istio.Enabled to false explicitly 

      spec:
  ingress:
    istio:
      enabled: false

      It will be changed as:

        ingress:
    contour:
      enabled: false
    istio:
      enabled: false
    kourier:
      enabled: false

      All "false" means "Kourier.Enabled = true" so it is not a serious problem but it is confusable.

      	if !ks.Spec.Ingress.Istio.Enabled && !ks.Spec.Ingress.Kourier.Enabled && !ks.Spec.Ingress.Contour.Enabled {
		ks.Spec.Ingress.Kourier.Enabled = true
	}

              markusthoemmes Markus Thömmes (Inactive)
              rhn-support-knakayam Kenjiro Nakayama (Inactive)
              Martin Gencur Martin Gencur
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: