Uploaded image for project: 'Knative Serving'
  1. Knative Serving
  2. SRVKS-669

ksvcs don't become ready in namespace with a "control-plane" label

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • 1.14.0
    • 1.11.0
    • Operator
    • False
    • False
    • Undefined
    • Serverless Sprint 194 & 195

      Some of knative webhooks (e.g. mutatingwebhookconfiguration webhook.serving.knative.dev ) has

        namespaceSelector:
          matchExpressions:
          - key: webhooks.knative.dev/exclude
            operator: DoesNotExist
          - key: control-plane
            operator: DoesNotExist
      

      which explicitly excludes namespaces labelled with "control-plane"

      The original purpose is apparently a hack for Azure AKS , see https://github.com/knative/pkg/blob/master/webhook/resourcesemantics/validation/reconcile_config.go#L153-L156 , https://github.com/knative/pkg/issues/1590 )

      This causes issues with kubeflow interoperability, which uses their own "control-plane" labels.

              markusthoemmes Markus Thömmes (Inactive)
              maschmid@redhat.com Marek Schmidt
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: