Description

Webhook fails to update Kservice with K_SINK and K_CE_OVERRIDES environmental variables, if Knative service has name given. This is often the case as Knative CLI create such resource.

The error:

Saw the following changes without a name change (-old +new): spec.template.metadata.name
{*v1.RevisionTemplateSpec}.Spec.PodSpec.Containers[0].Env[?->1]:
	+: v1.EnvVar: "{Name:K_SINK Value:http://broker-ingress.knative-eventing.svc.cluster.local/demo/default ValueFrom:nil}"
{*v1.RevisionTemplateSpec}.Spec.PodSpec.Containers[0].Env[?->2]:
	+: v1.EnvVar: "{Name:K_CE_OVERRIDES Value: ValueFrom:nil}"

The Kservice was created by:

kn service create showcase \
  --image quay.io/cardil/knative-serving-showcase:2-send-event

The Knative definition webhook-error.sink-1.ksvc.yaml
The SinkBinding definition webhook-error.sink-1.sb.yaml

Reproduction

1. Deploy a ksvc via kn
2. Create a sinkbinding to it

Expected

SinkBinding should update ksvc and set K_SINK and K_CE_OVERRIDES environmental variables

Actual

The above error can be seen in webhook (knative-serving namespace) logs