-
Bug
-
Resolution: Done
-
Normal
-
1.5.0
-
None
-
Serverless Sprint 181
On clusters that upgraded to 1.5.0, we have a number of orphaned Istio VirtualService entries left around we need to clean up. From our long-running devint cluster that upgraded from 1.4.1 to 1.5.0:
$ oc get virtualservice -l "serving.knative.dev/route" --all-namespaces
NAMESPACE NAME GATEWAYS HOSTS AGE
markito event-display [knative-serving/cluster-local-gateway knative-serving/knative-ingress-gateway] [event-display.markito event-display.markito.apps.devint.openshiftknativedemo.org event-display.markito.svc event-display.markito.svc.cluster.local] 6d20h
markito event-display-mesh [mesh] [event-display.markito event-display.markito.svc event-display.markito.svc.cluster.local] 6d20h
markito kiosk [knative-serving/cluster-local-gateway knative-serving/knative-ingress-gateway] [kiosk.markito kiosk.markito.apps.devint.openshiftknativedemo.org kiosk.markito.svc kiosk.markito.svc.cluster.local v1-kiosk.markito v1-kiosk.markito.apps.devint.openshiftknativedemo.org v1-kiosk.markito.svc v1-kiosk.markito.svc.cluster.local v2-kiosk.markito v2-kiosk.markito.apps.devint.openshiftknativedemo.org v2-kiosk.markito.svc v2-kiosk.markito.svc.cluster.local] 27d
markito kiosk-mesh [mesh] [kiosk.markito kiosk.markito.svc kiosk.markito.svc.cluster.local v1-kiosk.markito v1-kiosk.markito.svc v1-kiosk.markito.svc.cluster.local v2-kiosk.markito v2-kiosk.markito.svc v2-kiosk.markito.svc.cluster.local] 27d
serverless-demo frontend [knative-serving/cluster-local-gateway knative-serving/knative-ingress-gateway] [frontend.serverless-demo frontend.serverless-demo.apps.devint.openshiftknativedemo.org frontend.serverless-demo.svc frontend.serverless-demo.svc.cluster.local] 6d19h
serverless-demo frontend-mesh [mesh] [frontend.serverless-demo frontend.serverless-demo.svc frontend.serverless-demo.svc.cluster.local] 6d19h
serverless-demo kiosk [knative-serving/cluster-local-gateway knative-serving/knative-ingress-gateway] [kiosk.serverless-demo kiosk.serverless-demo.apps.devint.openshiftknativedemo.org kiosk.serverless-demo.svc kiosk.serverless-demo.svc.cluster.local] 6d19h
serverless-demo kiosk-mesh [mesh] [kiosk.serverless-demo kiosk.serverless-demo.svc kiosk.serverless-demo.svc.cluster.local] 6d19h
utilities test-portal [knative-serving/cluster-local-gateway knative-serving/knative-ingress-gateway] [test-portal.utilities test-portal.utilities.apps.devint.openshiftknativedemo.org test-portal.utilities.svc test-portal.utilities.svc.cluster.local] 41d
utilities test-portal-mesh [mesh] [test-portal.utilities test-portal.utilities.svc test-portal.utilities.svc.cluster.local] 41d
All of these VirtualServices have a serving.knative.dev/route label and an annotation of networking.knative.dev/ingress.class: istio.ingress.networking.knative.dev. Ideally, we'd list all VirtualServices in the cluster with this label set and delete the VirtualService if we see that its corresponding Knative Ingress object is now using Kourier for ingress.
The impact of this is if a customer explicitly chooses to use Service Mesh with Knative Services post-1.5.0, they'll have these orphaned VirtualServices sitting around that will now get in the way as traffic routing should still happen via Kourier even for Knative Services that are part of a mesh.
- causes
-
SRVKS-500 Remove clean up code for orphaned VirtualService
- Closed