Uploaded image for project: 'Knative Serving'
  1. Knative Serving
  2. SRVKS-370

Cluster-scoped webhook.serving.knative.dev MutatingWebhookConfiguration ownerReferences a namespace-scoped Deployment

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • 1.4.0
    • 1.2.0
    • None
    • None

      The webhook.serving.knative.dev MutatingWebhookConfiguration (which is a cluster-scoped object) has an owner reference to namespaces-scoped Deployment. This is illegal per https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#owners-and-dependents "Cluster-scoped dependents can only specify cluster-scoped owners, but not namespace-scoped owners")

      apiVersion: admissionregistration.k8s.io/v1beta1
kind: MutatingWebhookConfiguration
metadata:
  creationTimestamp: "2019-12-03T03:52:06Z"
  generation: 1
  name: webhook.serving.knative.dev
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: Deployment
    name: webhook
...

      This seems to cause the webhook to be deleted (and recreated by the operator) whenever gc runs

      oc logs -n openshift-kube-controller-manager kube-controller-manager-ip-10-0-132-158.us-west-1.compute.internal  -c kube-controller-manager-5 | grep webhook.serving.knative.dev | grep "delete object"
I1203 03:51:56.161054       1 garbagecollector.go:518] delete object [admissionregistration.k8s.io/v1beta1/MutatingWebhookConfiguration, namespace: , name: webhook.serving.knative.dev, uid: 34d23fed-1580-11ea-834b-067ed3862ad9] with propagation policy Background

              Unassigned Unassigned
              maschmid@redhat.com Marek Schmidt
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: