Uploaded image for project: 'Knative Serving'
  1. Knative Serving
  2. SRVKS-301

Adding cluster-local label to existing service does not remove Route

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • 1.2.0
    • 1.1.0
    • None
    • Serverless Sprint 174

      When I create a Knative Service it will create Knative route in the same namespace and another openshift Route in istio-system namespace.

      Later, when I add a label serving.knative.dev/visibility=cluster-local, both routes remain unchanged. I'd expect the openshift Route to be removed and the Knative route to be changed so that the new URL ends with .cluster.local. But it doesn't happen.

      The visibility in Ingress remains External IP after I add the label:

      apiVersion: networking.internal.knative.dev/v1alpha1
      kind: Ingress
      metadata:
        annotations:
          networking.knative.dev/ingress.class: istio.ingress.networking.knative.dev
          serving.knative.dev/creator: kube:admin
          serving.knative.dev/lastModifier: kube:admin
        creationTimestamp: "2019-10-17T08:25:16Z"
        generation: 1
        labels:
          serving.knative.dev/route: sample
          serving.knative.dev/routeNamespace: myproject
        name: sample
        namespace: myproject
        ownerReferences:
        - apiVersion: serving.knative.dev/v1alpha1
          blockOwnerDeletion: true
          controller: true
          kind: Route
          name: sample
          uid: a05a16ff-f0b7-11e9-a668-0eba73b4a206
        resourceVersion: "63935"
        selfLink: /apis/networking.internal.knative.dev/v1alpha1/namespaces/myproject/ingresses/sample
        uid: a5f49ca6-f0b7-11e9-a668-0eba73b4a206
      spec:
        rules:
        - hosts:
          - sample.myproject.svc.cluster.local
          - sample.myproject.apps.ocp42mg-26-ocf-ocp4-aws-release-internal-mgencur.openshift-aws.rhocf-dev.com
          http:
            paths:
            - retries:
                attempts: 3
                perTryTimeout: 10m0s
              splits:
              - appendHeaders:
                  Knative-Serving-Namespace: myproject
                  Knative-Serving-Revision: sample-dqq4h
                percent: 100
                serviceName: sample-dqq4h
                serviceNamespace: myproject
                servicePort: 80
              timeout: 10m0s
          visibility: ExternalIP
        visibility: ExternalIP 

       

      When I add the label at the beginning when creating the service the openshift Route is not created and the URL correctly includes .cluster.local.

       

       

       

       {{}}

              rhn-support-knakayam Kenjiro Nakayama (Inactive)
              mgencur Martin Gencur (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: