-
Bug
-
Resolution: Done
-
Undefined
-
TP1
Running the serving conformance/runtime testsuite on OCP 4.2 with --resolvabledomain, the TestMustHaveHeadersSet fails
--- FAIL: TestMustHaveHeadersSet (11.38s) service.go:112: Creating a new Service must-have-headers-set-eerjohpp. crd.go:44: resource {<nil> <nil> <*>{&TypeMeta{Kind:,APIVersion:,} &ObjectMeta{Name:must-have-headers-set-eerjohpp,GenerateName:,Namespace:,SelfLink:,UID:,ResourceVersion:,Generation:0,CreationTimestamp:0001-01-01 00:00:00 +0000 UTC,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{},Annotations:map[string]string{},OwnerReferences:[],Finalizers:[],ClusterName:,Initializers:nil,} {0 <nil> <nil> <nil> <nil> {0 <nil> <nil> <*>&ObjectMeta{Name:,GenerateName:,Namespace:,SelfLink:,UID:,ResourceVersion:,Generation:0,CreationTimestamp:0001-01-01 00:00:00 +0000 UTC,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{},Annotations:map[string]string{},OwnerReferences:[],Finalizers:[],ClusterName:,Initializers:nil,}} {0 [{ { <*>true 100 <nil>}}]}} {{0 <nil>} {<nil> <nil> <nil>} { }}} <nil>} service.go:127: Waiting for Service "must-have-headers-set-eerjohpp" to transition to Ready. service.go:132: Checking to ensure Service Status is populated for Ready service must-have-headers-set-eerjohpp service.go:138: Getting latest objects Created by Service must-have-headers-set-eerjohpp service.go:141: Successfully created Service must-have-headers-set-eerjohpp header_test.go:187: forwarded = for=66.187.233.202;host=must-have-headers-set-eerjohpp.serving-tests.apps.example.com;proto=http;proto-version=""; want: valid Forwarded header per RFC7239
I suspect the problematic part is proto-version="" , which may be just a wrong check in the tests, as an empty quoted string should be allowed per https://tools.ietf.org/html/rfc7230#section-3.2.6