Uploaded image for project: 'Knative Serving'
  1. Knative Serving
  2. SRVKS-1249

Domain mapping deployments are not being deleted when upgrading from from 1.31 to 1.32

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Major Major
    • 1.33.1
    • 1.31.0, 1.32.0, 1.33.0
    • None
    • None
    • Important

      Domain mapping deployments were removed in 1.32 as code was moved in the controller deployment.
      Although upstream the operator can clean up old resources: https://github.com/knative/serving/issues/15247#issuecomment-2144441036 this is not triggered downstream.
      Customers should be able to workaround this by removing the resources listed here: https://github.com/knative/serving/blob/main/pkg/cleanup/cmd/cleanup/cleanup.go#L58-L69.

      To reproduce:

      Apply:

      ---
      apiVersion: v1
      kind: Namespace
      metadata:
        name: openshift-serverless
      ---
      apiVersion: operators.coreos.com/v1
      kind: OperatorGroup
      metadata:
        name: serverless-operators
        namespace: openshift-serverless
      spec: {}
      ---
      apiVersion: operators.coreos.com/v1alpha1
      kind: Subscription
      metadata:
        name: serverless-operator
        namespace: openshift-serverless
      spec:
        channel: stable
        installPlanApproval: Manual
        name: serverless-operator
        source: redhat-operators
        sourceNamespace: openshift-marketplace
        startingCSV: serverless-operator.v1.31.0
      ---
      
      oc get installplans.operators.coreos.com -n openshift-serverless
      NAME            CSV                           APPROVAL   APPROVED
      install-hp2cp   serverless-operator.v1.31.0   Manual     false
      
      # patch the plan
       oc patch installplan.operators.coreos.com/install-hp2cp -n openshift-serverless --type merge --patch '{"spec":{"approved":true }}'
      
      # install Serving by applying
      
      apiVersion: operator.knative.dev/v1beta1
      kind: KnativeServing
      metadata:
        name: knative-serving
        namespace: knative-serving
      
      
      # then upgrade Serverless to 1.32  and observe dm pods:
      NAME                                                          READY   STATUS      RESTARTS   AGE
      activator-7f4fc9b6d8-hlzvf                                    2/2     Running     0          2m2s
      activator-7f4fc9b6d8-rqcrc                                    2/2     Running     0          2m18s
      autoscaler-6d455d4679-9v5gz                                   2/2     Running     0          2m5s
      autoscaler-6d455d4679-sdjhv                                   2/2     Running     0          2m18s
      autoscaler-hpa-56cc6cd56b-kkjdk                               2/2     Running     0          2m17s
      autoscaler-hpa-56cc6cd56b-zrzq2                               2/2     Running     0          2m5s
      controller-54c876564b-5v6wj                                   2/2     Running     0          2m2s
      controller-54c876564b-ptj86                                   2/2     Running     0          2m18s
      domain-mapping-98d8789cf-jfndq                                2/2     Running     0          6m25s
      domain-mapping-98d8789cf-ql6x8                                2/2     Running     0          6m25s
      domainmapping-webhook-6b6ff886bb-fj7vn                        2/2     Running     0          6m25s
      domainmapping-webhook-6b6ff886bb-qmvf9                        2/2     Running     0          6m25s
      storage-version-migration-serving-serving-1.10-1.31.0-cnjnw   0/1     Completed   0          6m24s
      storage-version-migration-serving-serving-1.11-1.32.0-26g9w   0/1     Completed   0          2m16s
      webhook-5bdd775f66-8tgdp                                      2/2     Running     0          2m17s
      webhook-5bdd775f66-l7xxs                                      2/2     Running     0          2m2s
      

              dsimansk@redhat.com David Simansky
              skontopo@redhat.com Stavros Kontopoulos
              Michal Vinkler Michal Vinkler
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Created:
                Updated:
                Resolved: