Description of problem:

In 1.19.4 catalog-<id>-type is not present, when upgraded to 1.20.2, the catalog type defaults to artifacthub even if the URL points to tektonhub. Need a check similar to SRVKP-9248 for the custom catalog post upgrade.

Workaround

Manually configure the catalog type post upgrade

Prerequisites (if any, like setup, operators/versions):

Steps to Reproduce

Install OSP 1.19.4 

Add custom catalog in tektonconfig

catalog-1-id: "custom"
catalog-1-name: "tekton"
catalog-1-url: "https://api.custom.hub/v1"
catalog-1-type: "tektonhub"

catalog-2-id: "artifact"
catalog-2-name: "tekton-catalog-tasks"
catalog-2-url: "https://artifacthub.io"
catalog-2-type: "artifacthub" 

In 1.19.4, tektonconfig doesn't have a catalog-type field in tektonconfig

catalog-0-id: public
catalog-0-name: tekton
catalog-0-url: https://api.hub.tekton.dev/v1
catalog-1-id: custom
catalog-1-name: tekton
catalog-1-url: https://tekton-hub-api.apps.sri.ch
catalog-2-id: artifact
catalog-2-name: tekton-catalog-tasks
catalog-2-url: https://artifacthub.io

Now, upgrade to 1.20.2 and check the tektonconfig

Actual results:

            catalog-0-id: public
            catalog-0-name: tekton
            catalog-0-type: artifacthub
            *catalog-0-url: https://api.hub.tekton.dev/v1*
            catalog-1-id: custom
            catalog-1-name: tekton
            catalog-1-type: artifacthub
            *catalog-1-url: https://tekton-hub-api.apps.sri.ch*
            catalog-2-id: artifact
            catalog-2-name: tekton-catalog-tasks
            catalog-2-type: artifacthub
            *catalog-2-url: https://artifacthub.io*

Expected results:

Tektonhub URL should have catalogtype as tektonhub

Similarly for artifacthub

Reproducibility (Always/Intermittent/Only Once):

Always

Additional info (Such as Logs, Screenshots, etc):

 *