Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-9708

PaC Gitlab Push events only compare first 20 changed files

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • None
    • Pipelines 1.20.0, Pipelines 1.18.1, Pipelines 1.19.3, Pipelines 1.21.1
    • Pipelines as Code
    • 1
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide
      Before this fix, when PaC is processing a Gitlab Push event, cel variable `files` and the cel method `pathChanged()` would only consider up to 20 files in the commit. After this fix, all files modified by the HEAD commit will be considered in `files` and `pathChanged()` in CEL evaluation.
      Show
      Before this fix, when PaC is processing a Gitlab Push event, cel variable `files` and the cel method `pathChanged()` would only consider up to 20 files in the commit. After this fix, all files modified by the HEAD commit will be considered in `files` and `pathChanged()` in CEL evaluation.
    • Bug Fix
    • Proposed

      Description of problem:

      When trying to trigger a PLR using PaC with a push event in Gitlab, the logic for detecting the files changed only looks at the first 20 files returned from the Gitlab API and does not perform any paging. The cel variable `files` also includes only 20 files when more than 20 files are changed

      Workaround

      None

      Prerequisites (if any, like setup, operators/versions):

      Steps to Reproduce

       See repro here

       

      Actual results:

      Expected results:

      Reproducibility (Always/Intermittent/Only Once):

      Acceptance criteria: 

       

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

       

       *

              rh-ee-athorp Andrew Thorp
              rh-ee-athorp Andrew Thorp
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: