Description of problem:

When configuring an ApprovalTask (openshift-pipelines.org/v1alpha1), the custom parameter timeout is ignored by the controller. The task continues to wait indefinitely or until the default global timeout is reached. However, if the standard Tekton timeout field is used at the PipelineRun task specification level, the timeout works correctly.

Workaround

Configure timeout via pipeline run or approval task

Prerequisites (if any, like setup, operators/versions):

OSP 1.21.0

Steps to Reproduce

• Create a Pipeline resource that uses the ApprovalTask.

• Define the timeout using the params list via pipeline.

• Set the value to a short duration (eg, 1m)

• Trigger the pipeline.

• Wait for 1 minute without approving.

Actual results:

The task ignores the 1 minute parameter and remains in the running/pednign state

Expected results:

The Approval Task should transition to a Failed/Timeout state exactly after 1 minute.

Reproducibility (Always/Intermittent/Only Once):

Always

Additional info (Such as Logs, Screenshots, etc):

example from the doc

apiVersion: tekton.dev/v1
kind: Pipeline
metadata:
  name: example-manual-approval-pipeline
spec:
  tasks:
  - name: example-manual-approval-task
    taskRef:
      apiVersion: openshift-pipelines.org/v1alpha1
      kind: ApprovalTask
    params:
    - name: approvers
      value:
      - user1
      - user2
      - user3
    - name: description
      value: Example manual approval task - please approve or reject
    - name: numberOfApprovalsRequired
      value: '2'
    - name: timeout
      value: '1m'