Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-9159

Some retryable dry-run-validation errors cause pipelineruns to fail

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • None
    • Pipelines 1.19.0, Pipelines 1.20.0, Pipelines 1.21.0
    • Tekton Pipelines
    • None
    • 2
    • False
    • Hide

      None

      Show
      None
    • False
    • With this change, unknown kubeapi errors during TaskRef and PipelineRef validation no longer cause PipelineRuns and TaskRuns to fail. Explicit Validation errors will still cause the Run to fail.
    • Bug Fix

      Description of problem:

      During Dry-Run validation of Task References, some retryable errors (such as Resource Quota evaluation timeouts) are not handled correctly and cause the PipelineRun to fail with an error like:

      Pipeline my-pipelinerun can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task "resolver type bundles\nname = build-image\n": retryable error validating referenced object build-image: Internal error occurred: resource quota evaluation timed out 

      This is because even when the getTask function returns a retryable error (indicated by the error snippet "retryable error validating referenced object"), the handling is done by IsErrTransient which uses the kubeapi when checking for timeout errors. The error message's snippet "Internal error occurred: " indicates that the kubeAPI did not return a timeout error but a server error, so IsErrTransient returns false.

       

      Checking if getTask returned an ErrCouldntValidateObjectRetryable should resolve the issue

      Workaround

      Prerequisites (if any, like setup, operators/versions):

      Steps to Reproduce

       # <steps>

       

      Actual results:

      Expected results:

      Reproducibility (Always/Intermittent/Only Once):

      Acceptance criteria: 

       

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

       

       *

              rh-ee-athorp Andrew Thorp
              rh-ee-athorp Andrew Thorp
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: