Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-9152

push tag events buggy with release-branches

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • Pipelines 1.20.0
    • Pipelines as Code
    • False
    • Hide

      None

      Show
      None
    • False

      Description of problem:

      When pushing a tag which targets a release-branch (not the main branch), open Pull Requests targeting the release branch may cause the push event to be dropped by the skip-push-event-for-pr-commits feature.

      Workaround

      Two workarounds:

      • Pushing an empty commit to the release branch and moving the tag to the new commit
      • Commenting  /retest ... branch:... also forces the PLR to start

        Prerequisites (if any, like setup, operators/versions):

      Setup Pipelines as Code with a connected Github repository.

      Steps to Reproduce

      • In Github, author a branch release-123
      • Author a PipelineRun in that branch which is triggered using an on-cel expression like:
      pipelinesascode.tekton.dev/on-cel-expression: |
            (event == "pull_request" && body.action != "ready_for_review") || (
              event == "push" && target_branch.matches("^(master|release-.*|refs/tags/.*)$")
            ) 
      • Create a new branch with some changes and push it:
      $ git checkout -b other-branch release-123
      $ echo "a change" > README.md
      $ git add README.md
      $ git commit -m "make some change"
      $ git push 
      • In Github, open a pull request from other-branch to {{release-123, }}do not merge{{{}
        {}}}
      • Create and push a tag on the release-123 branch:
      $ git checkout release-123
      $ git tag v1
      $ git push --tags 

      Actual results:

      The PipelineRun is not triggered and PaC logs something akin to skipping push event for commit <sha> as it belongs to pull request #<pr-id>

      Expected results:

      The PipelineRun should start

      Reproducibility (Always/Intermittent/Only Once):

      Always

      Acceptance criteria: 

       

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

       

       *

              rh-ee-zashaikh Zaki Shaikh
              rh-ee-athorp Andrew Thorp
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: